Skip to content

BUG: Duplicate player_id values in load_ff_opportunity() #23

@nolanpopp

Description

@nolanpopp

The load_ff_opportunity() function returns duplicate records with the same (game_id, player_id) combination but different player names.

import nflreadpy as nfl
import pandas as pd 

# Load FF opportunity data for 2013 season
df = nfl.load_ff_opportunity([2013]).to_pandas()

# Filter out rows where player_id or full_name is None/null
df_valid = df[
    df['player_id'].notna() & 
    df['full_name'].notna() &
    (df['player_id'] != '') &
    (df['full_name'] != '')
].copy()

# Check for duplicates on (game_id, player_id)
duplicates = df_valid[df_valid.duplicated(subset=['game_id', 'player_id'], keep=False)]
duplicates_sorted = duplicates.sort_values(['game_id', 'player_id'])

# Display the problematic records
print("Duplicate (game_id, player_id) combinations found:")
print(duplicates_sorted[['game_id', 'player_id', 'full_name', 'position']].to_string())

# Count total duplicates
dup_count = len(duplicates_sorted) // 2  # Divide by 2 since each pair appears twice
print(f"\nTotal duplicate pairs: {dup_count}")

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions