fix(compute/deploy): check compute product entitlement when creating service#1179
Open
Integralist wants to merge 7 commits intomainfrom
Open
fix(compute/deploy): check compute product entitlement when creating service#1179Integralist wants to merge 7 commits intomainfrom
Integralist wants to merge 7 commits intomainfrom
Conversation
87d9554 to
76c451f
Compare
76c451f to
5539575
Compare
kpfleming
reviewed
Jun 25, 2024
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
Integralist
commented
Jun 26, 2024
| @@ -17,12 +17,30 @@ import ( | |||
| "github.com/fastly/cli/pkg/useragent" | |||
Contributor
Author
There was a problem hiding this comment.
@kpfleming feel free to rebase and take over this PR if you want to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes are happening in this PR but the primary change is to check the entitlement the user has to the Compute product and to display a message informing them that the new service they're about to create will be part of a trial access (unless they are already on a trial, or they've paid for access).
Additional changes worth noting: