fix: use address 0.0.0.0 in Kubernetes env (#579)#580
fix: use address 0.0.0.0 in Kubernetes env (#579)#580mcollina merged 2 commits intofastify:masterfrom
Conversation
004fecc to
4faac51
Compare
climba03003
left a comment
There was a problem hiding this comment.
I still in favor of multiple methods for the detection.
For example, different cloud platform may result in derivation of behavior which means that this environment variables are not always set.
https://stackoverflow.com/questions/66470062/aks-not-creating-kubernetes-service-host-and-kubernetes-service-port-environment
4faac51 to
fc526c6
Compare
|
A proper implementation should be follow
We are not authenticating for |
Good point, I'll update the PR with the additional check. I was looking for something similar in the docs, but couldn't find it 🙂 |
Checklist
npm run testandnpm run benchmarkand the Code of conduct
This PR adds a check so that it automatically use 0.0.0.0 when running inside a Kubernetes environment.