Skip to content

fix(index): do not set header if authenticate is false#126

Merged
kibertoad merged 1 commit intomasterfrom
fix/basic
Dec 2, 2023
Merged

fix(index): do not set header if authenticate is false#126
kibertoad merged 1 commit intomasterfrom
fix/basic

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented Dec 1, 2023

The readme states that if authenticate: false is set then the response header will not be set, however this is not the case.
It sets the header to "false" as caught in these test failures.

This PR ensures no header is added if authenticate: false is set.

Checklist

Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Fdawgs Fdawgs requested a review from a team December 2, 2023 09:40
@kibertoad kibertoad merged commit d314d9b into master Dec 2, 2023
@kibertoad kibertoad deleted the fix/basic branch December 2, 2023 09:58
@Uzlopak
Copy link
Copy Markdown
Contributor

Uzlopak commented Dec 2, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants