fix: resolve 6 failing Playwright E2E tests #2042
Open
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add custom "Invalid email address" validation message to Zod schemas in login, signup, and recover-password routes (fixes 4 tests) - Wait for success toast before polling mailcatcher in password reset tests (fixes 2 tests) - Fix sign-up with existing email test to wait for first signup and use proper toBeVisible() assertion (fixes 1 test) - Fix signUpNewUser utility to wait for signup completion before navigating 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 6 failing Playwright E2E tests by addressing root causes in both the frontend validation schemas and test implementations.
Issues Fixed
Email Validation Messages (4 tests)
{ message: "Invalid email address" }to email validation in:login.tsxsignup.tsxrecover-password.tsxPassword Reset Tests (2 tests)
Sign Up with Existing Email (1 test)
.click()to proper.toBeVisible()Root Cause Fix
signUpNewUserutility to wait for signup completion (waitForURL("/login")) instead of immediately navigating awayTest Plan
Files Changed
frontend/src/routes/login.tsxfrontend/src/routes/signup.tsxfrontend/src/routes/recover-password.tsxfrontend/tests/reset-password.spec.tsfrontend/tests/sign-up.spec.tsfrontend/tests/utils/user.ts