Merged
Conversation
- Update farzai/transport dependency from ^1.2 to ^2.1 - Migrate ClientBuilder to use new TransportBuilder API (withBaseUri, setLogger) - Replace Request class with RequestBuilder in PendingRequest - Remove PsrResponseTrait usage and implement PSR-7 delegation directly in AbstractResponseDecorator - Add jsonOrNull() and toArray() methods to AbstractResponseDecorator - Fix typo: isSuccessfull() → isSuccessful() - Fix throw() return type to static for proper chaining - Add guzzlehttp/guzzle as dev dependency - Add .phpunit.cache to .gitignore
parsilver
changed the title
PHP 8.1 is EOL and pestphp/pest ^2.15 can no longer resolve dependencies on PHP 8.1 with --prefer-lowest due to brianium/paratest requiring PHP 8.2+.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
============================================
- Coverage 85.10% 82.36% -2.74%
- Complexity 137 155 +18
============================================
Files 21 21
Lines 443 482 +39
============================================
+ Hits 377 397 +20
- Misses 66 85 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pestphp/pest ^2 cannot resolve dependencies on PHP 8.5 with --prefer-lowest due to brianium/paratest version conflicts.
pestphp/pest ^2 does not support PHP 8.5 in any version.
- AbstractResponseDecorator: test jsonOrNull, toArray, PSR-7 delegation - ResponseWithValidateErrorCode: test null error code, throw chaining - ClientBuilder: test setHttpClient, setLogger, setRetries - PendingRequest: test string body, no-options request, path normalization, createResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
farzai/transportfrom^1.2to^2.1and migrate the codebase to the new Transport v2 API.Changes
farzai/transportto^2.1, addguzzlehttp/guzzleas dev dependencyTransportBuilderfluent API (withBaseUri,setLogger)Requestclass withRequestBuilderPsrResponseTrait, implement PSR-7 delegation directly, addjsonOrNull()andtoArray()methodsthrow()return type tostaticfor proper chainingisSuccessfull()toisSuccessful().phpunit.cacheto.gitignoreTest plan
composer installsucceeds with updated dependenciesvendor/bin/pestto confirm all tests pass