Conversation
fanzeyi
left a comment
fanzeyi
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a few comments.
Curious: are you working on this on behalf of Databricks or in personal capacity?
| #ifdef EDEN_HAVE_SERVICEROUTER | ||
| ConfigSetting<bool> enableServiceRouter{ | ||
| "facebook:enable-service-router", | ||
| fb_has_servicerouter(), | ||
| this}; | ||
| #else |
There was a problem hiding this comment.
I don't think we define this for open source build? If it is defined we might want to fix that instead of removing this line.
| #include <folly/portability/Unistd.h> | ||
|
|
||
| #include "common/rust/shed/hostcaps/hostcaps.h" | ||
| //#include "common/rust/shed/hostcaps/hostcaps.h" |
There was a problem hiding this comment.
Instead of removing it, maybe
| //#include "common/rust/shed/hostcaps/hostcaps.h" | |
| #ifdef EDEN_HAVE_SERVICEROUTER | |
| #include "common/rust/shed/hostcaps/hostcaps.h" | |
| #endif |
| # This software may be used and distributed according to the terms of the | ||
| # GNU General Public License version 2. | ||
|
|
||
| rust_static_library(rust_backingstore CRATE backingstore FEATURES fb) |
There was a problem hiding this comment.
Can you make this optional? I think we have a CMake variable to check if it is Facebook internal build or not.
|
@fanzeyi We (Databricks) are looking into ways to improve our monorepo performance and Eden looks promising. This PR was a step I took to validate if it actually works outside of FB and how supported it is. Do you know if anyone has ever deployed Eden outside of FB? |
|
@gabrielrussoc Ah, that's cool! I interned there a few years ago. 😀 I don't think anyone has deployed EdenFS outside Facebook. The git support we have is very basic (if that's the route you are considering). We do deploy the CMake build internally on certain platforms because of build system limitations, so it mostly work other than these corners where FB environment is expected. |
|
@fanzeyi I interned at FB a few year ago too 😅
It's not very clear to me what kind of Git support there is. Let me open up an issue for better visibility and ask a few questions there |
|
OSS builds are working again |
4 participants
mastertomain.fbfeature