Improve component type check in getComponentKey.#9464
Merged
bvaughn merged 2 commits intofacebook:masterfrom Apr 25, 2017
Merged
Improve component type check in getComponentKey.#9464bvaughn merged 2 commits intofacebook:masterfrom
bvaughn merged 2 commits intofacebook:masterfrom
Conversation
The sequence ``` component && typeof component === 'object' ``` checks whether component is any JavaScript object except document.all. Since document.all cannot occur here, this can be replaced with the usual ``` typeof component === 'object' && component !== null ``` sequence, which yields true for all JavaScript objects and is well optimized by all JavaScript engines.
Collaborator
|
Looks good to me, thanks. Let’s wait for CI. |
gaearon
approved these changes
Apr 20, 2017
Contributor
Author
|
That being said: it obviously filters out callable objects still. |
Contributor
|
Looks like you need to run if (
typeof component === "object" &&
component !== null &&
component.key != null
) { |
Contributor
Author
|
Done. Although it didn't split it into three lines. |
Collaborator
|
Likely because we haven’t updated to the last version yet (we will soon). |
Contributor
Author
|
Anything else missing? |
Contributor
|
Oh, my bad. My local prettier did but I may have been using a diff version. :) No, looks good. Thanks for following up! |
Contributor
Author
|
Thanks! |
Collaborator
|
Thanks @bmeurer! |
koba04
added a commit
to koba04/react
that referenced
this pull request
Apr 26, 2017
koba04
added a commit
to koba04/react
that referenced
this pull request
May 8, 2017
koba04
added a commit
to koba04/react
that referenced
this pull request
Jun 12, 2017
koba04
added a commit
to koba04/react
that referenced
this pull request
Jun 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence
checks whether component is any JavaScript object except document.all.
Since document.all cannot occur here, this can be replaced with the
usual
sequence, which yields true for all JavaScript objects and is well
optimized by all JavaScript engines.