Use charAt instead of string indexing#9424
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
While I don’t mind in principle, I’m not sure it would be a good approach for you. We will likely break this again in future versions, and will likely keep breaking because we don’t have fixtures for that. So I’d say React might not be right fit for you since we target IE9+, and will also likely require some polyfills in React 16 (Map and Set). I don’t think we can target even more restrictive environments than IE9. |
|
Yeah, I totally understand. I'm going to see about server-rendering the markup instead - it just would've been convenient to have it all work out. Thanks for giving this a lookover! |
Related: #2651
This replaces the
event[0]character access withcharAt.We're currently trying to use
reactwithPrinceXML, which does not have character access by index implemented, causing a failure to render.