Conversation
This makes it easier to override things in www.
This prevents a circular dependency between ReactGKJSModule and ReactDOM
This was referenced Mar 10, 2017
Collaborator
Author
|
This is the fix for ReactPerf circular dep: 723b402. Since rollup/rollup-plugin-commonjs#176 was blocking me, I fixed up the bundles by hand: https://gist.github.com/gaearon/ff710198c82f60470c8c4092b9204065. Right now I'm stuck on an error related to |
Closed
Contributor
|
You could note in the final PR that this closes #4927 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just opening PR so we can keep track of progress.
I'll close this one before merging anything so that @trueadm gets the squashed commit 😉
This PR has been closed. A new PR to track this progress has been setup:
#9327