Embed JSX filename paths relative to repo root#6778
Merged
sophiebits merged 1 commit intofacebook:masterfrom May 16, 2016
Merged
Embed JSX filename paths relative to repo root#6778sophiebits merged 1 commit intofacebook:masterfrom
sophiebits merged 1 commit intofacebook:masterfrom
Conversation
Test Plan: Changed the preprocessor to log the output of babel.transform and saw ``` var _jsxFileName = 'src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js'; ``` in the resulting output, instead of an absolute path.
ghost
added
Member
|
👍 |
Member
|
Question as I look at this and #6398 - this transform only affects our tests right? 6398 adds the info to the warning so others will get if if they use that transform but we only have JSX in our tests so it shouldn't affect prod (eg, we'll never ship anything with |
Collaborator
Author
|
Right. For our purposes it would probably be fine to only apply the transform in tests (though of course most apps will want to always enable it in dev mode – we'll have to tell people in the next release notes). |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Test Plan: Changed the preprocessor to log the output of babel.transform and saw ``` var _jsxFileName = 'src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js'; ``` in the resulting output, instead of an absolute path. (cherry picked from commit 6afd510)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
Test Plan: Changed the preprocessor to log the output of babel.transform and saw ``` var _jsxFileName = 'src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js'; ``` in the resulting output, instead of an absolute path. (cherry picked from commit 6afd510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: Changed the preprocessor to log the output of babel.transform and saw
in the resulting output, instead of an absolute path.
@zpao