Started setting both props.class and props.className for DOM elements#5976
Closed
jimfb wants to merge 1 commit intofacebook:masterfrom
Closed
Started setting both props.class and props.className for DOM elements#5976jimfb wants to merge 1 commit intofacebook:masterfrom
jimfb wants to merge 1 commit intofacebook:masterfrom
Conversation
1304828 to
76260b5
Compare
Contributor
|
Is there a plan to support |
Contributor
Author
|
If we were to change |
Contributor
|
@jimfb updated the pull request. |
|
@jimfb has this been reviewed and is it likely to be included in a v15 minor release? |
Contributor
Author
|
@mikeybox No, there is a long road and many discussions between here and there. |
|
@jimfb thanks for the update |
Collaborator
|
I’ll close because this doesn’t merge cleanly and we don’t seem to want to do this in the short term. We might want to reopen some day but I’d expect we’d have a more solid plan around this by that time. |
This was referenced Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly for shits and giggles, but I was curious to see how often this would fire on my devserver (ie. curious if it actually creates a migration burden, because code wins arguments).
Fixes #5926, FWIW. This would need lots more discussion before we could actually consider merging such a thing.