Fix children to be a prop in the blog post example#5695
Merged
gaearon merged 2 commits intofacebook:masterfrom Dec 21, 2015
gaearon:patch-2
Merged
Fix children to be a prop in the blog post example#5695gaearon merged 2 commits intofacebook:masterfrom gaearon:patch-2
gaearon merged 2 commits intofacebook:masterfrom
gaearon:patch-2
Conversation
Contributor
|
This looks wrong to me too: On line 12: In this traditional UI model, it is up to you to take care On line 165 do the braces make sense? is-a () |
Collaborator
Author
|
Thanks @cody, fixed those too. |
Contributor
|
@gaearon updated the pull request. |
Collaborator
Author
|
ping @spicyj, can I merge this? |
Collaborator
|
Sure. Then |
gaearon
added a commit
that referenced
this pull request
Dec 21, 2015
Fix children to be a prop in the blog post example
gaearon
added a commit
that referenced
this pull request
Dec 21, 2015
Fix children to be a prop in the blog post example (cherry picked from commit 50af034)
Collaborator
Author
|
Just did this. Should I also do this for my other PR (#5702)? |
Collaborator
|
Just for the website. Shouldn't matter for the other one because everyone should be looking at master on github. |
Collaborator
Author
|
Got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whoops. Other examples seem fine.
cc @zpao