Don't throw for onClick={false} in initial render#5018
Merged
sophiebits merged 1 commit intofacebook:masterfrom Oct 1, 2015
Merged
Don't throw for onClick={false} in initial render#5018sophiebits merged 1 commit intofacebook:masterfrom
sophiebits merged 1 commit intofacebook:masterfrom
Conversation
I accidentally regressed this in facebook#3246. Now this matches what we already checked for updates.
sebmarkbage
added
GH Review: accepted
and removed
CLA Signed
GH Review: review-needed
labels
sophiebits
added a commit
that referenced
this pull request
Oct 1, 2015
Don't throw for onClick={false} in initial render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally regressed this in #3246. Now this matches what we already checked for updates.