Typecheck React DevTools extension main script#35519
Merged
eps1lon merged 2 commits intofacebook:mainfrom Jan 16, 2026
Merged
Conversation
github-actions
bot
added
the
React Core Team
hoxyq
approved these changes
Jan 16, 2026
Comment on lines
491
to
494
| store = (null: any); | ||
| bridge = (null: any); | ||
| render = (null: any); | ||
| root = (null: any); |
Contributor
There was a problem hiding this comment.
Why not $FlowFixMe these, to explicitly mark that it needs to be fixed in a future?
Collaborator
Author
There was a problem hiding this comment.
Good point. Pushed.
eps1lon
deleted the
sebbie/01-15-typecheck_react_devtools_extension_main_script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably we ignore the passed theme in
onThemeChangedand just do a plain re-render (introduced in #33992).Remove emission of unused
extensionEditorPaneShownandextensionEditorPaneHiddenevents (added in #33968).