[compiler] Switch to track setStates by aliasing and id instead of identifier names

[jorge-cab]

Summary:
This makes the setState usage logic much more robust. We no longer rely on identifierName.

Now we track when a setState is loaded into a new promoted identifier variable and track this in a map setStateLoaded map.

For other types of instructions we consider the setState to be being used. In this case we record its usage into the setStateUsages map.

Test Plan:
We expect no changes in behavior for the current tests

---

Stack created with Sapling. Best reviewed with ReviewStack.

• [compiler] Prevent local state source variables from depending on other state #35044
• [compiler] Don't validate when effect cleanup function depends on effect localized setState state derived values #35020
• -> [compiler] Switch to track setStates by aliasing and id instead of identifier names #34973
• [compiler] Update ValidateNoDerivedComputationsInEffects_exp to log the error instead of throwing #34972

[mofeiZ]

we should be able to remove this isSetStateType (as discussed)
this will keep the logic cleaner (we rely on just dataflow instead of a hybrid of data-flow and typing)

[mofeiZ]

I think you should be able to remove this as well

[mofeiZ]

I would move line 312 to line 315:

// invariant: everything in the loads sidemap is a 'valid' setState

if (instr is LoadLocal) {
  // check if there is an entry for `instr.value.place...` in the `loads` sidemap
  // if there is, insert the loadlocal lvalue into `loads` as well
} else {
  // is this a possible "source" of setStates
  if (ifSetStateType(...)) {
    // this is a root setState
  }
}