[DevTools] Minify backend #34507
Merged
[DevTools] Minify backend #34507
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 16, 2025
| optimization: { | ||
| minimize: false, | ||
| minimize: !__DEV__, | ||
| minimizer: [ |
Collaborator
Author
There was a problem hiding this comment.
Same options as in packages/react-devtools-extensions/webpack.config.js. I'll merge these two configs once they're similar enough.
eps1lon
force-pushed
the
sebbie/09-16-_devtools_minify_backend
branch
from
2682f93 to
3f701f7
Compare
eps1lon
commented
Sep 17, 2025
| __DEV__: true, | ||
| __DEV__, | ||
| __PROFILE__: false, | ||
| __DEV____DEV__: true, |
Collaborator
Author
There was a problem hiding this comment.
Seems like a mistake. react-devtools-extensions/webpack.config.js doesn't define that var either.
3 tasks
hoxyq
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we disabled minification for the backend in #19369, we didn't have sourcemaps. As of #28730 we do so we can minify it again.
Minification isn't just about reducing parsed size but also about reducing runtime overhead via various compiler optimizations. We only use Terser at the moment but should use Closure in the future.