Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
force-pushed
the
pr31774
branch
2 times, most recently
from
ad7b4b0 to
2ea7804
Compare
mofeiZ
commented
Dec 14, 2024
| }, | ||
| { | ||
| name: 'function-scope-beats-module-scope', | ||
| name: 'todo-function-scope-does-not-beat-module-scope', |
Contributor
Author
There was a problem hiding this comment.
See attached snap fixture -- playground and the babel plugin diverged before this PR
Compiler playground now runs the entire program through `babel-plugin-react-compiler` instead of a custom pipeline which previously duplicated function inference logic from `Program.ts`. In addition, the playground output reflects the tranformed file (instead of a "virtual file" of manually concatenated functions). This helps with the following: - Reduce potential discrepencies between playground and babel plugin behavior. See attached fixture output for an example where we previously diverged. - Let playground users see compiler-inserted imports (e.g. `_c` or `useFire`) This also helps us repurpose playground into a more general tool for compiler-users instead of just for compiler engineers. - imports and other functions are preserved. We differentiate between imports and globals in many cases (e.g. `inferEffectDeps`), so it may be misleading to omit imports in printed output - playground now shows other program-changing behavior like position of outlined functions and hoisted declarations - emitted compiled functions do not need synthetic names
josephsavona
approved these changes
Dec 16, 2024
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
yesss this is so good! The changes to the HMR setting make sense
mofeiZ
commented
Dec 16, 2024
| @@ -1,4 +1,5 @@ | |||
| function TestComponent(t0) { | |||
| import { c as _c } from "react/compiler-runtime"; | |||
Contributor
Author
There was a problem hiding this comment.
Note that we now print inserted imports. Other program level changes (e.g. Options.gating, outlining) should work as expected without hardcoding
mofeiZ
commented
Dec 16, 2024
| import { c as _c } from "react/compiler-runtime"; | ||
| function useFoo(propVal) { | ||
| const $ = _c(2); | ||
| const t0 = (propVal.baz: number); |
Contributor
Author
There was a problem hiding this comment.
Flow now codegens and prints successfully. This means that Flow users can use playground without needing to edit / manually strip their annotations
mofeiZ
commented
Dec 16, 2024
| } else { | ||
| t0 = $[0]; | ||
| } | ||
| const x = t0 as number; |
Contributor
Author
There was a problem hiding this comment.
Typescript also codegens successfully 🎉 No type annotation changes needed
davesnx
added a commit
to davesnx/react
that referenced
this pull request
Dec 18, 2024
…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (facebook#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (facebook#31761) Enable disableDefaultPropsExceptForClasses (facebook#31804) Turn on useModernStrictMode in test renderers (facebook#31769) [compiler][ez] Add shape for global Object.keys (facebook#31583) [compiler] Context variables as dependencies (facebook#31582) [compiler] Add fire to known React APIs (facebook#31795) [compiler] Add option for firing effect functions (facebook#31794) [compiler][be] Logger based debug printing in test runner (facebook#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (facebook#31581) [compiler] Repro for aliased captures within inner function expressions (facebook#31770) [compiler][be] Playground now compiles entire program (facebook#31774) [Flight] Color and badge non-primary environments (facebook#31738) [Flight] Emit Deduped Server Components Marker (facebook#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (facebook#31736) Clean up context access profiling experiment (facebook#31806) [Flight] Stack Parallel Components in Separate Tracks (facebook#31735) Flag for requestPaint (facebook#31805)
This was referenced Dec 18, 2024
This was referenced Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler playground now runs the entire program through
babel-plugin-react-compilerinstead of a custom pipeline which previously duplicated function inference logic fromProgram.ts. In addition, the playground output reflects the tranformed file (instead of a "virtual file" of manually concatenated functions).This helps with the following:
_coruseFire)This also helps us repurpose playground into a more general tool for compiler-users instead of just for compiler engineers.
We differentiate between imports and globals in many cases (e.g.
inferEffectDeps), so it may be misleading to omit imports in printed outputStack created with Sapling. Best reviewed with ReviewStack.