Add additional field for ART reconciler#2593
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Nov 25, 2014
Merged
Conversation
ART, just like MultiChild adds an expando property to manage it's diffing state. This is ugly and bad. We should be moving this state outside the component for use by the diffing algorithm. This state is not needed by components nested in composites, and varies by diffing algorithm. It sucks that I have to add it to every component just to support ART, but that's the quickest solution, other than disabling preventExtensions. At least now we know that it sucks.
Collaborator
|
Okay. |
sebmarkbage
added a commit
that referenced
this pull request
Nov 25, 2014
Add additional field for ART reconciler
This was referenced Apr 29, 2020
This was referenced Jul 28, 2020
This was referenced May 5, 2021
This was referenced Jan 16, 2022
This was referenced Apr 7, 2022
This was referenced Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ART, just like MultiChild adds an expando property to manage it's diffing
state. This is ugly and bad. We should be moving this state outside the
component for use by the diffing algorithm. This state is not needed by
components nested in composites, and varies by diffing algorithm.
It sucks that I have to add it to every component just to support ART,
but that's the quickest solution, other than disabling preventExtensions.
At least now we know that it sucks.