Replace deprecated optimist library with yargs and update tabs to spaces#2589
Closed
dennis-johnson-dev wants to merge 1 commit intofacebook:masterfrom
Closed
Replace deprecated optimist library with yargs and update tabs to spaces#2589dennis-johnson-dev wants to merge 1 commit intofacebook:masterfrom
dennis-johnson-dev wants to merge 1 commit intofacebook:masterfrom
Conversation
Member
|
I just deleted the syntax.js file in #2601 because we didn't actually use it (and updating the optimist dependency there is messy because it's synced with an internal file). Can you rebase and then we can merge this. |
dennis-johnson-dev
force-pushed
the
master
branch
from
4d82ca6 to
aee73cc
Compare
Contributor
Author
|
Ok, I rebased and am hopefully good to go. I noticed that you had reverted the commit removing the file so I just left it as is. Cheers. |
Contributor
Author
|
@zpao Anything else I can do for this? I can also just close it if it's not really necessary. |
Member
|
Yea, I think I'll just close it. Thanks for the initiative though. It's only used for building docs. If we revamp the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA is complete.