Add automatic retry to download script #20704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c0aef6:
|
rickhanlonii
approved these changes
Feb 1, 2021
bvaughn
approved these changes
Feb 1, 2021
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
I don't feel strongly about this. :)
acdlite
force-pushed
the
add-automatic-retry-to-download-script
branch
from
931e939 to
ad5417a
Compare
If build job is still pending, the script will continously poll until it reaches the retry limit. I've set the limit at 10 minutes, since our CI pipeline almost always finishes before that.
acdlite
force-pushed
the
add-automatic-retry-to-download-script
branch
from
ad5417a to
5c0aef6
Compare
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
If build job is still pending, the script will continously poll until it reaches the retry limit. I've set the limit at 10 minutes, since our CI pipeline almost always finishes before that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #20703
If build job is still pending, the script will continuously poll until it reaches the retry limit.
I've set the limit at 10 minutes, since our CI pipeline almost always finishes before that.