Use webpack to make browser builds#1937
Closed
sophiebits wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Run `webpack` to try it. Things to fix:
- [ ] grunt integration
- [ ] banner should have "React with Add-Ons" or "JSXTransformer", not always "React"
```
raw gz Compared to last run
= = build/JSXTransformer-previous.js
-4852 -4089 build/JSXTransformer.js
= = build/react-previous.min.js
= = build/react-test.js
= = build/react-webpack.js
+5743 -625 build/react-with-addons.js
-19304 -3636 build/react-with-addons.min.js
+5619 -149 build/react.js
-17906 -3384 build/react.min.js
```
Contributor
|
ooooh daaamn 👍 |
Collaborator
Author
|
Takes ~6 seconds on my machine to build all five files when everything's cached, but you can use |
Member
|
I'm winning for the dev builds :P |
Collaborator
Author
|
Pretty sure I can make the dev builds smaller if we care… |
Member
|
Cool, because browser-pack has |
Collaborator
Author
|
Oh, you lost all the license and @providesModule comments. |
Contributor
|
Oooh, this is sweet. |
Closed
Member
|
Going to close this out. We can revisit if we need to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
webpackto try it. Things to fix: