[react-a11y] Add react-ui/accessibility to bundle build#16804
Merged
trueadm merged 4 commits intofacebook:masterfrom Sep 17, 2019
Merged
[react-a11y] Add react-ui/accessibility to bundle build#16804trueadm merged 4 commits intofacebook:masterfrom
trueadm merged 4 commits intofacebook:masterfrom
Conversation
Details of bundled changes.Comparing: f40ceb0...b7b3efe react-ui
|
trueadm
requested review from
bchocho and
threepointone
and removed request for
bchocho
Contributor
|
Why are the accessibility-related components being bundled together rather than separately? |
Contributor
Author
|
@necolas I'll split them up. Actually, if you could review my other PR then I can land that first, as that renames the files, it makes more sense. |
acdlite
approved these changes
Sep 17, 2019
Collaborator
acdlite
left a comment
acdlite
left a comment
There was a problem hiding this comment.
The part that fixes the FB bundle's external requires looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to test the experimental accessibility components internally at FB, we need to be able to build the latest components so they get included in our syncs. This includes an accessibility bundle so we can test this out internally. Also, I made sure that our mappings for FB externals gets re-written appropriately, as our internal system won't recognise a
react-uipackage.