Improve warning for invalid class contextType#15142
Merged
gaearon merged 3 commits intofacebook:masterfrom Mar 19, 2019
Merged
Conversation
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: df7b87d...a123591 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
aweary
approved these changes
Mar 18, 2019
| 'This can also happen due to a circular dependency, so ' + | ||
| 'try moving the createContext() call to a separate file.'; | ||
| } else if (typeof contextType !== 'object') { | ||
| addendum = ' However, it is set to ' + typeof contextType + '.'; |
Contributor
There was a problem hiding this comment.
I think we can add "a" here to make it a little clearer
addendum = ' However, it is set to a ' + typeof contextType + '.';That way it reports "set to a string" instead of "set to string", which sounds better. Same goes for numbers, symbols, and functions.
| } else if (contextType._context !== undefined) { | ||
| // <Context.Consumer> | ||
| addendum = ' Did you accidentally pass the Context.Consumer instead?'; | ||
| } else { |
Contributor
There was a problem hiding this comment.
Add another branch for arrays?
else if (Array.isArray(contextType)) {
addendum = 'However, it is set to an array.'
}
Collaborator
Author
There was a problem hiding this comment.
Seems very unlikely to happen
Contributor
There was a problem hiding this comment.
🤷♂️ seems like it could happen if you import the wrong value. I figured that if it happens it would be weird to see.
However, it is set to an object with keys {0, 1, 2, 3, 4, 5, 6...100000}
Collaborator
Author
There was a problem hiding this comment.
Arrays are pretty rare as export values so I don't think it's worth handling.
sebmarkbage
reviewed
Mar 19, 2019
| didWarnAboutInvalidateContextType.add(type); | ||
|
|
||
| let addendum = ''; | ||
| if (contextType === null) { |
Contributor
There was a problem hiding this comment.
Sometimes it is nice to be able to conditionally set it:
class Foo {
static contextType = isServerEnvironment ? null : Context;
}This provides no way to do that while also ensuring you stay declarative.
Is null really a common mistake? I'm guessing not since it's the only one you don't have a descriptive message for.
Collaborator
Author
There was a problem hiding this comment.
Nope. Agree let’s omit it.
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Mar 27, 2019
* Improve warning for invalid class contextType * Don't warn for null * Grammar
Closed
This was referenced Aug 12, 2019
This was referenced Feb 4, 2020
This was referenced Feb 17, 2020
This was referenced Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds extra warning for when
contextTypeexists but isundefined. This can happen due to module cycles in legacy environments (see #13969) and can be very difficult to debug.SSR and regular version are copy pasted.
I separated the DEV check outside the actual code because unlike in the prod code, we actually do want to warn for
undefined-but-not-truthy code path.