Adds experimental event API scaffolding#15108
Merged
trueadm merged 2 commits intofacebook:masterfrom Mar 14, 2019
Merged
Conversation
trueadm
changed the title
Contributor
|
Now I'm really curious about what you've worked on internally at Facebook. |
Contributor
threepointone
approved these changes
Mar 14, 2019
|
React: size: 0.0%, gzip: -0.0% ReactDOM: size: 🔺+0.1%, gzip: 0.0% Details of bundled changes.Comparing: 679402a...34d0cc9 react
react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
gaearon
approved these changes
Mar 14, 2019
sebmarkbage
reviewed
Mar 14, 2019
Contributor
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Can you do a follow up to wrap in feature flags?
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Adds experimental event API scaffolding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some scaffolding to React needed for the event API experiment that we're testing out internally at Facebook. The API will be behind a
enableEventAPIflag to ensure the logic is kept in isolation.This scaffolding in this PR doesn't add any functionality. This PR inserts placeholders, symbols for the new fibers, functions and tags/types in preparation for follow up PRs that add the implementations. In the interests of making this experimental event API easier to review and consume, I've opted to create lots of smaller PRs.
This PR is only one part of the work to add the event API, so expect other PRs that expand on this and fill in the implementations. #15036 is the previous part of work.
I plan on writing up an RFC explaining this event API, along with how the internals work (such as the new symbols) once we've had a chance to iron out some details internally.