Revert "Do not bind topLevelType to dispatch"#13674
Merged
Conversation
Collaborator
Author
|
GitHub is so weird. I don't know why it shows those separate "revert" commits even though I revert just one. It should be fine after squash though. |
Contributor
|
Bummer. Sorry to just catch wind of this :(. |
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
* Revert "Do not bind topLevelType to dispatch (facebook#13618)" This reverts commit 0c9c591.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Revert "Do not bind topLevelType to dispatch (facebook#13618)" This reverts commit 0c9c591.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13618
This breaks some tests using SimulateNative :-(.
Don't know what's the cause but if it breaks us, it can break other people too.
We could investigate this more but I think it's not high priority for now so I'll just get this in to unblock syncing (and 16.5.2)