Initialize React prop name/attribute name mapping without Map #12353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Mar 12, 2018
| ['httpEquiv', 'http-equiv'], | ||
| ]).forEach((attributeName, name) => { | ||
| ['acceptCharset', 'className', 'htmlFor', 'httpEquiv'].forEach((name, i) => { | ||
| const attributeName = ['accept-charset', 'class', 'for', 'http-equiv'][i]; |
Contributor
There was a problem hiding this comment.
might be clearer if it was an array of array pairs? Like maybe just the argument to the original map. Less likely to accidentally shift one array but not the other
Using `new Map(iterable)` isn't supported in IE11, so it ends up trying to iterate through an empty map and these attributes don't get defined in properties. Since this is only run once on startup inlining the attributeName array is probably fine.
aweary
force-pushed
the
fix-ie11-attribute-name-bug
branch
from
c722931 to
108ad51
Compare
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
…ok#12353) Using `new Map(iterable)` isn't supported in IE11, so it ends up trying to iterate through an empty map and these attributes don't get defined in properties. Since this is only run once on startup inlining the attributeName array is probably fine.
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…ok#12353) Using `new Map(iterable)` isn't supported in IE11, so it ends up trying to iterate through an empty map and these attributes don't get defined in properties. Since this is only run once on startup inlining the attributeName array is probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12349. See #12349 (comment).
Using
new Map(iterable)isn't supported in IE11, so it ends up trying to iterate through an empty map and these attributes don't get defined in properties. Since this is only run once on startup inlining theattributeNamearray is probably fine.