Conversation
Added a hint about how to enable debugging on real devices.
Contributor
|
Awesome thanks! |
Contributor
|
After #652 is updated this will be easier to do (won't have to modify React's source). |
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
React Native has this issue where when using a `TextInput` with `multiline` set as `true`, the text is aligned to the top on iOS and to the center on Android by default, which causes confusion, evidenced by the amount of likes in [this comment](facebook#13897 (comment)). I believe the `textAlignVertical` default should be changed when `multiline` is `true`, but since I don't know if there are any reasons the issue I linked was closed, I suggest this is at least documented.
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Mar 10, 2021
* Add nullability checks (facebook#704) * Update RCTCxxBridge.mm * add nullability checks * CI should run on PRs to future stable branches (facebook#718) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (facebook#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * update podfile.lock * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (facebook#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * update podfile.lock * windows dep updates to 63 Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Sergi Mansilla <sergi@sergimansilla.com> Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a hint about how to enable debugging on real devices.