fix ReactNativeART arc drawing on Android#5856
fix ReactNativeART arc drawing on Android#5856dgladkov wants to merge 3 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@dgladkov updated the pull request. |
2 similar comments
|
@dgladkov updated the pull request. |
|
@dgladkov updated the pull request. |
|
cc @mkonicek |
|
This problem can be reproduced when using react-art's Wedge shape (https://github.com/reactjs/react-art/blob/master/src/Wedge.art.js). I can create a sample RN project that illustrates the error if needed. |
|
@dgladkov A sample would be great. Thanks. |
|
Created a project to illustrate the bug https://github.com/dgladkov/RNArtArcDrawingBug |
|
Fixes #5311 |
|
What's the test plan? Do you have some screenshots before / after? |
|
@spicyj would you mind taking a look at this pull request? It's been a while since the last commit was reviewed. |
|
@dgladkov Can you add some screenshots please so we can see what it looks like? |
|
@mkonicek The author added 'before' screenshots illustrating the bug here: https://github.com/dgladkov/RNArtArcDrawingBug Do you need @dgladkov to add 'after' screenshots as well? |
|
This PR had a bug in it. I submitted my own, including screenshots: #7049. |
|
@MikeOrtiz We could merge #7049, it's being reviewed now. |
Oh sorry @dgladkov I didn't see that, I look for a Test plan in the pull request summary, see https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md |
|
Thanks for the update @MikeOrtiz! |
5 participants
This patch fixes multiple problems with arc drawing on Android and makes it consistent with how
CGPathAddArcworks on iOS