fix[android]: fix bridgeless configuration to include DebuggingOverlay in react packages#43661
Closed
hoxyq wants to merge 1 commit intofacebook:mainfrom
Closed
fix[android]: fix bridgeless configuration to include DebuggingOverlay in react packages#43661hoxyq wants to merge 1 commit intofacebook:mainfrom
hoxyq wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java`, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Base commit: 575507d |
Contributor
|
This pull request has been merged in ad93680. |
huntie
pushed a commit
that referenced
this pull request
Apr 2, 2024
…y in react packages (#43661) Summary: Pull Request resolved: #43661 # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java`, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Reviewed By: cortinico Differential Revision: D55375350 fbshipit-source-id: 1d3cb6b5ad3c0248df1def9f37c8c49b308f4473
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
BridgelessDebugReactPackage.javato core, this was added in D43407534.ReactInstanceJavato addBridgelessDebugReactPackage, soDebuggingOverlayview manager will be included in the bridgeless build.RNTesterApplication.ktto NOT createMyLegacyViewManagerfor every possible viewManagerName, apart from"RNTMyNativeView", return null instead.Differential Revision: D55375350