Warn users if XCode is too old#43583
Closed
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
NickGerleman
force-pushed
the
export-D55149636
branch
from
772d55e to
21da04e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
NickGerleman
force-pushed
the
export-D55149636
branch
from
21da04e to
4cd696c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
Base commit: 0267ca0 |
NickGerleman
force-pushed
the
export-D55149636
branch
from
4cd696c to
fd083e9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
NickGerleman
force-pushed
the
export-D55149636
branch
from
fd083e9 to
b55d554
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
Summary: Fail during `pod install` if user's version of XCode is too old to avoid cryptic errors (e.g. reactwg/react-native-releases#163). I reused existing mechanism for version detection, though it may not be reliable for future versions of XCode. Changelog: [iOS][Changed] - Warn users during "pod install" if XCode is too old Differential Revision: D55149636
NickGerleman
force-pushed
the
export-D55149636
branch
from
b55d554 to
b6a22ed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55149636 |
Contributor
|
This pull request has been merged in 1021448. |
huntie
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: #43583 Fail during `pod install` if user's version of XCode is too old to avoid cryptic errors (e.g. reactwg/react-native-releases#163). I reused existing mechanism for version detection, though it may not be reliable for future versions of XCode. Changelog: [iOS][Changed] - Warn users during "pod install" if XCode is too old Reviewed By: dmytrorykun Differential Revision: D55149636 fbshipit-source-id: 78387ff19a6eb10f3ca0d4aa78e6b934ae3b0711
This was referenced Apr 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fail the build early if user's version of XCode is too old to avoid cryptic errors.
Changelog:
[iOS][Changed] - Warn users if XCode is too old
Differential Revision: D55149636