Update test-e2e-local to use source monorepo packages for RNTestProject#42899
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Update test-e2e-local to use source monorepo packages for RNTestProject#42899huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53484510 |
Base commit: 1570062 |
huntie
changed the title
huntie
force-pushed
the
export-D53484510
branch
2 times, most recently
from
69c31e8 to
a2cb3fa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53484510 |
huntie
force-pushed
the
export-D53484510
branch
from
a2cb3fa to
3826ef8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53484510 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…ct (facebook#42899) Summary: Pull Request resolved: facebook#42899 Updates the `test-e2e-local` script to bootstrap `/tmp/RNTestProject/` using the currently checked out repository as the source of truth for all monorepo packages (previously we only did this for the `react-native` package). This enables release testers to validate a release **before** physically publishing new dependency versions via `yarn bump-all-updated-packages`. We are able to reuse the `scripts/template/initialize.js` script that is currently used for E2E validation in CI. This sets up a local Verdaccio server during project install. NOTE: The time taken for `Build packages` + Verdaccio isn't ideal, I may explore a way to reuse the published package state in a future diff. Until then, this extra time (~1 min) will still be much less pain than the `bump-all-updated-packages` + commit process loop. Changelog: [Internal] Differential Revision: https://internalfb.com/D53484510
…ct (facebook#42899) Summary: Updates the `test-e2e-local` script to bootstrap `/tmp/RNTestProject/` using the currently checked out repository as the source of truth for all monorepo packages (previously we only did this for the `react-native` package). This enables release testers to validate a release **before** physically publishing new dependency versions via `yarn bump-all-updated-packages`. We are able to reuse the `scripts/template/initialize.js` script that is currently used for E2E validation in CI. This sets up a local Verdaccio server during project install. NOTE: The time taken for `Build packages` + Verdaccio isn't ideal, I may explore a way to reuse the published package state in a future diff. Until then, this extra time (~1 min) will still be much less pain than the `bump-all-updated-packages` + commit process loop. Changelog: [Internal] - Update test-e2e-local to use source monorepo packages for RNTestProject Reviewed By: lunaleaps Differential Revision: D53484510
huntie
force-pushed
the
export-D53484510
branch
from
3826ef8 to
3a2bf3d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53484510 |
Contributor
|
This pull request has been merged in e4135e9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updates the
test-e2e-localscript to bootstrap/tmp/RNTestProject/using the currently checked out repository as the source of truth for all monorepo packages (previously we only did this for thereact-nativepackage).This enables release testers to validate a release before physically publishing new dependency versions via
yarn bump-all-updated-packages.We are able to reuse the
scripts/template/initialize.jsscript that is currently used for E2E validation in CI. This sets up a local Verdaccio server during project install.Changelog: [Internal]
Differential Revision: D53484510