fix: PerfMonitor option not showing on iOS (Bridgeless)#42891
Closed
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Closed
fix: PerfMonitor option not showing on iOS (Bridgeless)#42891okwasniewski wants to merge 1 commit intofacebook:mainfrom
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Feb 6, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Hi @okwasniewski thank you for the fix. I left a couple of comments for which I'd like to know what are your thoughts.
okwasniewski
force-pushed
the
fix/perf-monitor
branch
from
bcf035e to
7fc5324
Compare
okwasniewski
force-pushed
the
fix/perf-monitor
branch
from
7fc5324 to
520e77e
Compare
cipolleschi
approved these changes
Feb 7, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for doing this! :D
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 2091400. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes PerfMonitor option not showing on iOS when running bridgeless. The
initializemethod is not called in bridgeless which causes this option to not be added. I've converted this approach to work for both bridgeless and non-bridgeless.Changelog:
[IOS] [FIXED] - Perf Monitor option not showing in Bridgeless
Test Plan:
Run RNTester, open Perf monitor