De-duplicate the logic for counting attachments

[jakub-trzebiatowski]

Summary:

De-duplicate the logic for counting attachments.

This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.

Changelog:

[INTERNAL] [CHANGE] - De-duplicate the logic for counting attachments

Test Plan:

[jakub-trzebiatowski]

@rozele Any chance you could review this?

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,066,833	+1
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,450,443	+11
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: cfc0ba0
Branch: main

[jakub-trzebiatowski]

@rozele I took a look at the "build_npm_package" check and it seems unrelated to my changes 🙂

[cipolleschi]

Hi @cubuspl42, thanks for the PR. I left a couple of comments.
One is just a nit, but the other is related to function visibility and public API and I think it would be better to address it.

What are your thoughts on this suggestion?

[cipolleschi]

I added some concrete suggestions on how to move forward.

[cipolleschi]

Thanks for your understanding and for applying the fixes.
CI is red but it is not due this PR: this morning Cocoapods released a new version (1.1.5.0) which is breaking. See more here.

[jakub-trzebiatowski]

@cipolleschi Thank you for reviewing and approving this PR! What is the next action point here? 🙂

[cipolleschi]

/rebase - this comment automatically rebase the PR on top of main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

I'm soooo sorry! I was sure we already merged this PR in main. 🤦
I'll proceed importing and have it landed.

[facebook-github-bot]

@cipolleschi merged this pull request in 69977d0.