feat: add nullable annotations to RCTBundleURLProvider#42293
Closed
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Closed
feat: add nullable annotations to RCTBundleURLProvider#42293okwasniewski wants to merge 1 commit intofacebook:mainfrom
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Jan 16, 2024
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
requested changes
Jan 16, 2024
okwasniewski
force-pushed
the
feat/objc-swift-annotations
branch
from
91cb378 to
8914dd3
Compare
cipolleschi
approved these changes
Jan 18, 2024
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 12e4a57. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds nullable annotations to
RCTBundleURLProvideralso allowing to return optional (the default that will be returned when metro is not running). Not having this may lead to crashes because Swift will try to unwrap optional with nil when metro is not running.Changelog:
[IOS] [ADDED] - add nullable annotations to RCTBundleURLProvider
Test Plan:
CI Green