fix: add build generated files to *ignore config

[okwasniewski]

Summary:

This PR adds build generated files to *ignore config files. This allows to locally run yarn lint

Changelog:

[INTERNAL] [ADDED] - Add build generated files to local config files

Test Plan:

CI Green

[okwasniewski]

cc: @huntie

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[huntie]

As a note, this hasn't been added globally because: 1/ not all of our packages follow this pattern yet, 2/ ideally (and open to debate!) even though we're in a monorepo, packages should self-specify their paths (e.g. in .gitignore, package.json#files), as if they were isolated.

However, I see there is a functional need to set this in .flowconfig and .prettierignore.

Requesting PR changes, to either:

• Include .flowconfig and .prettierignore changes but drop this entry (personal preference but again open to debate).
• Leave this entry included, but delete redundant .gitignore entries that are covered by this rule in each package.

[okwasniewski]

Packages that self-specify their ignore paths would be ideal however, eslint doesn't support that (eslint/eslint#13389, neither do prettier: prettier/prettier#4081).

If we delete this entry you are unable to run yarn lint locally, that's the output for me:

✖ 710 problems (18 errors, 692 warnings)
  18 errors and 655 warnings potentially fixable with the `--fix` option

And if we delete .gitignore from packages/ we will add dist folders to source control. If you don't want to duplicate this maybe we could remove packages .gitignore and move it to global .gitignore?

[huntie]

Ah my bad! I'm in line with the above 👍🏻👍🏻

I missed that this is .eslintignore and not .gitignore 😅

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,738,212	+1,224,553
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,109,071	+1,224,822
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 38d07eb
Branch: main

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by @okwasniewski in 1e0fc76.

^{When will my fix make it into a release? | Upcoming Releases}