Add tests in CI not to break Hermes-Xcode integration#37616
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Add tests in CI not to break Hermes-Xcode integration#37616cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
cipolleschi
force-pushed
the
export-D46265656
branch
from
733a4be to
2900dde
Compare
Base commit: d3e3599 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
cipolleschi
force-pushed
the
export-D46265656
branch
from
2900dde to
31a36a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
cipolleschi
force-pushed
the
export-D46265656
branch
from
31a36a3 to
fa236e7
Compare
cipolleschi
force-pushed
the
export-D46265656
branch
from
fa236e7 to
48c52bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
cipolleschi
force-pushed
the
export-D46265656
branch
from
48c52bd to
f956c62
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
cipolleschi
force-pushed
the
export-D46265656
branch
from
f956c62 to
f6fd21c
Compare
Summary: Pull Request resolved: facebook#37616 Add tests in CircleCI to avoid that changes in Hermes can break the Xcode integration. ## Changelog: [Internal] - Add CI tests to avoid to break the Hermes-Xcode integration Reviewed By: cortinico Differential Revision: D46265656 fbshipit-source-id: 49a36986e144149f0f412dde6488daba37c49fb6
cipolleschi
force-pushed
the
export-D46265656
branch
from
f6fd21c to
e64c1cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46265656 |
Contributor
|
This pull request has been merged in b0864fd. |
Szymon20000
pushed a commit
to Szymon20000/react-native
that referenced
this pull request
Jun 14, 2023
Summary: Pull Request resolved: facebook#37616 Add tests in CircleCI to avoid that changes in Hermes can break the Xcode integration. ## Changelog: [Internal] - Add CI tests to avoid to break the Hermes-Xcode integration Reviewed By: cortinico Differential Revision: D46265656 fbshipit-source-id: 176f1a33fe6944a68fb14b62e5c626fe30d296cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add tests in CircleCI to avoid that changes in Hermes can break the Xcode integration.
Changelog:
[Internal] - Add CI tests to avoid to break the Hermes-Xcode integration
Differential Revision: D46265656