Move LayoutMetrics and LayoutPrimitives from core to graphics folder#37609
Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Closed
Move LayoutMetrics and LayoutPrimitives from core to graphics folder#37609sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45904748 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45904748 |
sammy-SC
force-pushed
the
export-D45904748
branch
from
02fd41e to
ae68b21
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45904748 |
sammy-SC
force-pushed
the
export-D45904748
branch
from
ae68b21 to
bd8efad
Compare
koonkoon
reviewed
May 29, 2023
There was a problem hiding this comment.
Suggested change
| #import <react/renderer/components/view/AccessibilityPrimitives.h> | |
| #import <react/renderer/components/view/AccessibilityPrimitives.h> | |
There was a problem hiding this comment.
Suggested change
| #import <react/renderer/components/view/primitives.h> | |
| #import <react/renderer/components/view/primitives.h> |
…acebook#37609) Summary: Pull Request resolved: facebook#37609 changelog: [internal] Moving LayoutMetrics and LayoutPrimitives from core to graphics module. This is to enable different implementation for different platforms. Reviewed By: rubennorte Differential Revision: D45904748 fbshipit-source-id: b6d939ed446b05dc1ca1e18c4a6db6470df863e1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45904748 |
sammy-SC
force-pushed
the
export-D45904748
branch
from
bd8efad to
d88a42f
Compare
Contributor
|
This pull request has been merged in ce3ade8. |
Contributor
|
This pull request has been reverted by 9084ee1. |
Szymon20000
pushed a commit
to Szymon20000/react-native
that referenced
this pull request
Jun 14, 2023
…acebook#37609) Summary: Pull Request resolved: facebook#37609 changelog: [internal] Moving LayoutMetrics and LayoutPrimitives from core to graphics module. This is to enable different implementation for different platforms. Reviewed By: rubennorte Differential Revision: D45904748 fbshipit-source-id: a4e666d7c7390e87abdb09235f96655b63f451f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Moving LayoutMetrics and LayoutPrimitives from core to graphics module.
This is to enable different implementation for different platforms.
Reviewed By: rubennorte
Differential Revision: D45904748