fix: add mixed to aria-checked typings#34633
fix: add mixed to aria-checked typings#34633ankit-tailor wants to merge 3 commits intofacebook:mainfrom
Conversation
Base commit: 0d3596a |
|
@rubennorte has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 0d3596a |
|
There was an internal request to update the typescript types too. cc @lunaleaps |
lunaleaps
left a comment
There was a problem hiding this comment.
Hi @ankit-tailor! As Nicolas mentioned can we update the TS types here:
and other related places if any
|
Yes @lunaleaps, I'll do the necessary changes. |
|
@lunaleaps, Only ViewAccessibility props required the above changes, other than that everywhere else ViewAccessibility props are extended. |
|
@lunaleaps any updates on this? |
|
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @ankit-tailor in 7a19af7. When will my fix make it into a release? | Upcoming Releases |
Summary
aria-checkedprop should acceptmixedas value as given here and also accessibilityState.checked accepts mixed to represent checkboxes. This change refers to issue #34424 and PR #34524Changelog
[General] [Added] - Added
mixedvalue foraria-checked.Test Plan