feat: added aria-modal as alias for accessibilityViewIsModal(iOS)#34506
feat: added aria-modal as alias for accessibilityViewIsModal(iOS)#34506dakshbhardwaj wants to merge 11 commits intofacebook:mainfrom
Conversation
Base commit: 82e9c6a |
|
Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on |
@cipolleschi I have rebased it with |
Base commit: e8739e9 |
|
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…sibility-view-is-modal
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…sibility-view-is-modal
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…sibility-view-is-modal
| restProps['aria-modal'] !== null | ||
| ? restProps['aria-modal'] | ||
| : restProps.accessibilityViewIsModal, |
There was a problem hiding this comment.
| restProps['aria-modal'] !== null | |
| ? restProps['aria-modal'] | |
| : restProps.accessibilityViewIsModal, | |
| restProps['aria-modal'] ?? restProps.accessibilityViewIsModal, |
| this.props['aria-modal'] !== null | ||
| ? this.props['aria-modal'] | ||
| : this.props.accessibilityViewIsModal |
There was a problem hiding this comment.
| this.props['aria-modal'] !== null | |
| ? this.props['aria-modal'] | |
| : this.props.accessibilityViewIsModal | |
| this.props['aria-modal'] ?? this.props.accessibilityViewIsModal |
| this.props['aria-modal'] !== null | ||
| ? this.props['aria-modal'] | ||
| : this.props.accessibilityViewIsModal |
There was a problem hiding this comment.
| this.props['aria-modal'] !== null | |
| ? this.props['aria-modal'] | |
| : this.props.accessibilityViewIsModal | |
| this.props['aria-modal'] ?? this.props.accessibilityViewIsModal |
| this.props['aria-modal'] !== null | ||
| ? this.props['aria-modal'] | ||
| : this.props.accessibilityViewIsModal, |
There was a problem hiding this comment.
| this.props['aria-modal'] !== null | |
| ? this.props['aria-modal'] | |
| : this.props.accessibilityViewIsModal, | |
| this.props['aria-modal'] ?? this.props.accessibilityViewIsModal, |
| this.props['aria-modal'] !== null | ||
| ? this.props['aria-modal'] | ||
| : this.props.accessibilityViewIsModal |
There was a problem hiding this comment.
| this.props['aria-modal'] !== null | |
| ? this.props['aria-modal'] | |
| : this.props.accessibilityViewIsModal | |
| this.props['aria-modal'] ?? this.props.accessibilityViewIsModal |
|
@jacdebug i have pushed the changes |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @dakshbhardwaj in 095f19a. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds the
aria-modalprop to the components where it's used as requested on #34424, mapping web aria-modal to equivalent accessibilityViewIsModalChangelog
[General] [Added] - Add aria-modal prop to basic component
TestPlan
Checked manually we are receiving the values by props.