feat: adding aria-label alias for accessibilityLabel#34502
feat: adding aria-label alias for accessibilityLabel#34502Viraj-10 wants to merge 42 commits intofacebook:mainfrom
Conversation
|
Hi @necolas, I Just Wanted to know if this is the right way. I will add other components if it's good to go. Open to suggestions. |
Base commit: 5e1c4d4 |
Base commit: 5e1c4d4 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
necolas
left a comment
There was a problem hiding this comment.
Also needs tests or RN tester example alongside where ever any accessibilityLabel tests/examples live
|
Hi @Viraj-10, could you rebase your branch, please? |
@cipolleschi, okay |
|
@Viraj-10 I have to ask if you can rebase this PR again... Also thanks for applying the suggestions! |
|
There are some errors in CI, could you have a look at them, please? |
…bel-alias-for-accessibilitylabel
|
Hi @Viraj-10, there are still errors. You can see them here: https://app.circleci.com/pipelines/github/facebook/react-native/15336/workflows/555b206f-388d-4dbd-868e-4727297563be/jobs/283063 An example of those is: could you have a look at them? |
|
Hi @cipolleschi @necolas, Sorry for the delay. I guess I have added an alias in all the components possible. Please review Once and let me know. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…bel-alias-for-accessibilitylabel
…bel-alias-for-accessibilitylabel
|
Hi @cipolleschi, All test cases are passed and I have resolved all the merge conflicts. |
|
This pull request was successfully merged by @Viraj-10 in 720cdbc. When will my fix make it into a release? | Upcoming Releases |
Summary
#34424
Changelog
[General] [Added] - Add
aria-labelprop toButton,View,PressablecomponentTest Plan