You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds the Android only rows prop to TextInput as requested on #34424 mapping the existing numberOfLines prop to rows. This PR also updates the TextInputExample.android on the RNTester in order to facilitate the manual QA of this.
Changelog
[Android] [Added] - Add rows prop to TextInput component
Test Plan
On Android open the RNTester app and navigate to the TextInput page
Test the TextInput component through the Fixed number of lines section
Screen.Recording.2022-08-23.at.22.52.05.mov
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
Aug 24, 2022
Is there an equivalent to numberOfLines / rows for iOS, or do we need to implement it within the TextInput?
Unfortunately no @necolas, but I guess we could implement it using maximumNumberOfLines of NSTextContainer, should I add this new behavior here or in a follow-up PR?
@lunaleaps@necolas quick question about these new TextInput props, should we deprecate these old props that are being mapped e.g. #34444 (comment)? Should I open a PR for numberOfLines similar to #34492?
@lunaleaps@necolas quick question about these new TextInput props, should we deprecate these old props that are being mapped e.g. #34444 (comment)? Should I open a PR for numberOfLines similar to #34492?
Let's hold off on this. There's concern that people don't have time to actively migrate their callsites and will get noise. Sorry about the trouble!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Platform: AndroidAndroid applications.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the Android only
rowsprop to TextInput as requested on #34424 mapping the existingnumberOfLinesprop torows. This PR also updates the TextInputExample.android on the RNTester in order to facilitate the manual QA of this.Changelog
[Android] [Added] - Add rows prop to TextInput component
Test Plan
TextInputcomponent through theFixed number of linessectionScreen.Recording.2022-08-23.at.22.52.05.mov