accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic#34371
Closed
fabOnReact wants to merge 3 commits intofacebook:mainfrom
Closed
accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic#34371fabOnReact wants to merge 3 commits intofacebook:mainfrom
fabOnReact wants to merge 3 commits intofacebook:mainfrom
Conversation
<details><summary>testing accessibilityLabelledBy with TextInput</summary> <p> https://user-images.githubusercontent.com/24992535/183593138-7ced1974-6a06-4f0f-822a-1ade1edc7212.mp4 </p> </details> <details><summary>testing accessibilityLabelledBy with Switch</summary> <p>  </p> </details>
Base commit: ee33385 |
Base commit: 333ba59 |
huntie
reviewed
Aug 10, 2022
| /> | ||
| </View> | ||
| <View> | ||
| <Text nativeID="formLabel4">Enable Fielld</Text> |
Member
There was a problem hiding this comment.
Typo: Fielld -> Field
Perhaps we want to put this in its own <RNTesterBlock>, since it is a switch and doesn't act on the preceding fields (naming may be confusing). We could label this instead as a concrete example such as "Enable notifications", or more generically: "Switch example".
Contributor
Author
Perhaps we want to put this in its own <RNTesterBlock>, since it is a switch and doesn't act on the preceding fields (naming may be confusing). We could label this instead as a concrete example such as "Enable notifications", or more generically: "Switch example". https://github.com/facebook/react-native/pull/34371/files#r942608407
Contributor
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @fabriziobertoglio1987 in 9f43581. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…mic (facebook#34371) Summary: `accessibilityLabelledBy` accepts String or Array type. - The JavaScript Array type corresponds to java [ReadableArray][3] ([HybridData][4]) - The JavaScript String type corresponds to the java String Use [DynamicFromObject][5] to parse String to Dynamic. https://github.com/facebook/react-native/blob/e509f96baf5e523301a5c9567c416508ff20d175/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java#L222-L228 All credits to [grgr-dkrk][1] (PR facebook#32470). fixes [https://github.com/facebook/react-native/issues/30846][2] ## Changelog [Android] [Fixed] - accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic Pull Request resolved: facebook#34371 Test Plan: <details><summary>testing accessibilityLabelledBy with TextInput</summary> <p> https://user-images.githubusercontent.com/24992535/183593138-7ced1974-6a06-4f0f-822a-1ade1edc7212.mp4 </p> </details> <details><summary>testing accessibilityLabelledBy with Switch</summary> <p>  </p> </details> <details><summary>testing paper renderer after the fix</summary> <p> https://user-images.githubusercontent.com/24992535/183605619-01f1be64-788a-43bd-88b0-a7b2cad75148.mp4 </p> </details> [1]: https://github.com/grgr-dkrk [2]: facebook#30846 [3]: https://github.com/facebook/react-native/blob/e509f96baf5e523301a5c9567c416508ff20d175/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableArray.java#L1 [4]: https://github.com/facebookincubator/fbjni/blob/main/java/com/facebook/jni/HybridData.java [5]: https://github.com/facebook/react-native/blob/e509f96baf5e523301a5c9567c416508ff20d175/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java#L74 Reviewed By: lunaleaps Differential Revision: D38706360 Pulled By: huntie fbshipit-source-id: e4771552d3fddfad50f4d4cbbf971fe4a718e134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessibilityLabelledByaccepts String or Array type.Use DynamicFromObject to parse String to Dynamic.
react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
Lines 222 to 228 in e509f96
All credits to grgr-dkrk (PR #32470). fixes #30846
Changelog
[Android] [Fixed] - accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic
Test Plan
testing accessibilityLabelledBy with TextInput
2022-08-09.15-40-35.mp4
testing accessibilityLabelledBy with Switch
testing paper renderer after the fix
2022-08-09.16-42-58.mp4