ReactSlider extends AppCompatSeekBar#23304
Closed
dulmandakh wants to merge 4 commits intofacebook:masterfrom
Closed
ReactSlider extends AppCompatSeekBar#23304dulmandakh wants to merge 4 commits intofacebook:masterfrom
dulmandakh wants to merge 4 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
Generated by 🚫 dangerJS |
dulmandakh
changed the title
Contributor
|
Same here, let me know once this is ready to ship. |
dulmandakh
changed the title
dulmandakh
changed the title
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 6, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@dulmandakh merged commit 833429d into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactSlider to extend AppCompatSeekBar. [Android] [Changed] - ReactSlider extends AppCompatSeekBar Pull Request resolved: facebook#23304 Differential Revision: D13973636 Pulled By: cpojer fbshipit-source-id: 9aa160b186fcea593224c5760a2de0fc3a2b6f85
michalchudziak
pushed a commit
to michalchudziak/react-native-slider
that referenced
this pull request
Feb 8, 2019
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactSlider to extend AppCompatSeekBar. [Android] [Changed] - ReactSlider extends AppCompatSeekBar Pull Request resolved: facebook/react-native#23304 Differential Revision: D13973636 Pulled By: cpojer fbshipit-source-id: 9aa160b186fcea593224c5760a2de0fc3a2b6f85
james-watkin
added a commit
to james-watkin/react-native-slider
that referenced
this pull request
Dec 28, 2021
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactSlider to extend AppCompatSeekBar. [Android] [Changed] - ReactSlider extends AppCompatSeekBar Pull Request resolved: facebook/react-native#23304 Differential Revision: D13973636 Pulled By: cpojer fbshipit-source-id: 9aa160b186fcea593224c5760a2de0fc3a2b6f85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Google recommends to use AppCompat widgets, and this PR changes ReactSlider to extend AppCompatSeekBar.
Changelog
[Android] [Changed] - ReactSlider extends AppCompatSeekBar
Test Plan
CI is green and everything works as normal.