Remove undefined value on init cli command#22045
Remove undefined value on init cli command#22045ignacioola wants to merge 1 commit intofacebook:masterfrom
Conversation
|
Maybe we should be requiring every command to have a description instead of patching this here. For reference, this is where commanderjs defines it's help behavior. https://github.com/tj/commander.js/blob/master/index.js#L1083-L1101 cc @grabbou I'll land this in the mean time though, seems reasonable enough short term patch. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ignacioola merged commit 58732a8 into |
Summary: Fixes `undefined` description message when running `react-native init --help` on an existing React Native project. Pull Request resolved: facebook/react-native#22045 Differential Revision: D12878956 Pulled By: TheSavior fbshipit-source-id: ede329ca88a02013a6c2f75f1b762d89eacdb34f
Summary: Fixes `undefined` description message when running `react-native init --help` on an existing React Native project. Pull Request resolved: #22045 Differential Revision: D12878956 Pulled By: TheSavior fbshipit-source-id: ede329ca88a02013a6c2f75f1b762d89eacdb34f
|
Interesting @ignacioola - sorry to comment after that amount of time, but it's weird that you have run into this issue. Description itself is optional and we set Let's take a closer look here. Maybe |
|
I am moving this discussion to the CLI repository. |
Summary: Fixes `undefined` description message when running `react-native init --help` on an existing React Native project. Pull Request resolved: facebook#22045 Differential Revision: D12878956 Pulled By: TheSavior fbshipit-source-id: ede329ca88a02013a6c2f75f1b762d89eacdb34f
Fixes
undefineddescription message when runningreact-native init --helpon an existing React Native project.Test Plan:
Run the cli from
react-nativerepo:And see that the description no longer says
undefinedRelease Notes:
[CLI][BUGFIX][local-cli/cliEntry.js] - Fix undefined description message when running
initcli command help.