Skip to content

[Circle] Store JUnit artifacts#17792

Closed
hramos wants to merge 5 commits intofacebook:masterfrom
hramos:junit-artifacts
Closed

[Circle] Store JUnit artifacts#17792
hramos wants to merge 5 commits intofacebook:masterfrom
hramos:junit-artifacts

Conversation

@hramos
Copy link
Contributor

@hramos hramos commented Jan 30, 2018

Should help visualize failures more easily.

@pull-bot
Copy link

pull-bot commented Jan 30, 2018 •
edited
Loading

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

@facebook-github-bot label Needs more information

Attention: @hramos

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 30, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 30, 2018
facebook-github-bot
facebook-github-bot approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Contributor Author

hramos commented Jan 30, 2018

Will merge as part of #17794

@hramos hramos closed this Jan 30, 2018
@hramos hramos deleted the junit-artifacts branch February 12, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hramos @pull-bot @facebook-github-bot