Conversation
ghost
added
the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This was referenced Sep 1, 2016
reitblatt
pushed a commit
to reitblatt/proxygen
that referenced
this pull request
Dec 29, 2016
Summary: Updates to new URL and release 1.8.0. Closes facebook#113 Reviewed By: yfeldblum Differential Revision: D3802169 Pulled By: lanxi fbshipit-source-id: aba6f71dfd92c38cf5421efc806b8ca86a92bb26
reitblatt
pushed a commit
to reitblatt/proxygen
that referenced
this pull request
Dec 29, 2016
Summary: Updates to new URL and release 1.8.0. Closes facebook#113 Reviewed By: yfeldblum Differential Revision: D3802169 Pulled By: lanxi fbshipit-source-id: aba6f71dfd92c38cf5421efc806b8ca86a92bb26
reitblatt
pushed a commit
to reitblatt/proxygen
that referenced
this pull request
Dec 29, 2016
Summary: Updates to new URL and release 1.8.0. Closes facebook#113 Reviewed By: yfeldblum Differential Revision: D3802169 Pulled By: lanxi fbshipit-source-id: aba6f71dfd92c38cf5421efc806b8ca86a92bb26
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: facebook/sapling#113 GitHub Actions was failing at apt-get stage, error message suggested adding an apt-get update as remedy. Added in this diff and it indeed works. The actions build fails later on missing mio::net module when building mysql async, but that's unrelated to this change. Reviewed By: farnz Differential Revision: D34368662 fbshipit-source-id: f0a00da3ee740ae4443a328616e792ea615c922c
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to new URL and release 1.8.0.