docs: update link in md code blocks section#8975
Merged
slorber merged 2 commits intofacebook:mainfrom May 15, 2023
rbarbazz:patch-1
Merged
docs: update link in md code blocks section#8975slorber merged 2 commits intofacebook:mainfrom rbarbazz:patch-1
slorber merged 2 commits intofacebook:mainfrom
rbarbazz:patch-1
Conversation
Link for default bundled languages
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
3 tasks
slorber
approved these changes
May 15, 2023
website/docs/guides/markdown-features/markdown-features-code-blocks.mdx
Outdated
Show resolved
Hide resolved
slorber
added
the
pr: documentation
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the link for default bundled languages
Pre-flight checklist
If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.Motivation
The link to the base set of bundled languages was broken. I got the new link from the
prism-react-rendererREADME page.It's a permalink though, maybe we want to use the path instead (i.e.: https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts#L9-L24)?
Test Plan
N/A
Test links
Old link: https://docusaurus.io/docs/markdown-features/code-blocks#supported-languages
Deploy preview: https://deploy-preview-8975--docusaurus-2.netlify.app/docs/markdown-features/code-blocks/#supported-languages
Related issues/PRs
#8976