Update docs + pre wrap#1
Closed
JoelMarcey wants to merge 1 commit intofacebook:masterfrom
JoelMarcey:update-docs
Closed
Update docs + pre wrap#1JoelMarcey wants to merge 1 commit intofacebook:masterfrom JoelMarcey:update-docs
JoelMarcey wants to merge 1 commit intofacebook:masterfrom
JoelMarcey:update-docs
Conversation
ahmedre
approved these changes
Dec 14, 2016
docs/index.html
Outdated
|
|
||
| <title>TextLayoutBuilder</title> | ||
| <meta name="description" content="TextLayoutBuilder is an utility to build text Layouts easily on Android."> | ||
| <meta name="description" content="TextLayoutBuilder is a utility to build text ayouts easily on Android."> |
Contributor
There was a problem hiding this comment.
This should be layouts.
docs/index.html
Outdated
| </div> | ||
|
|
||
| <!-- Instructions --> | ||
| <div class="instructionsContainer alternate"> |
Contributor
There was a problem hiding this comment.
This should not use alternate class.
Contributor
There was a problem hiding this comment.
Please make sure the sections have alternate background colors. Downloads is using alternate. So the next section following it should not, and the one following that (line 166) should.
Update the docs a bit - consistency on the bullets by starting with verb - Moved Download section before Usage - editorial changes Added `pre-wrap` for pre blocks so that it can wrap on mobile devices as needed.
|
@sriramramani has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the docs a bit
Added
pre-wrapfor pre blocks so that it can wrapon mobile devices as needed.