Remove generated_points argument to RandomGenerator (#5186)#5186
Closed
esantorella wants to merge 1 commit intofacebook:mainfrom
Closed
Remove generated_points argument to RandomGenerator (#5186)#5186esantorella wants to merge 1 commit intofacebook:mainfrom
generated_points argument to RandomGenerator (#5186)#5186esantorella wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101824526. |
meta-codesync
Bot
changed the title
generated_points argument to RandomGeneratorgenerated_points argument to RandomGenerator (#5186)
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 21, 2026
Summary: **Context**: This was deprecated in Ax 1.0.0 and has not done anything since then. **This PR**: * Removes generated_points` argument to `RandomGenerator` * Removes places where this is passed (which would have been recursively triggering the warning) Reviewed By: saitcakmak Differential Revision: D101824526
esantorella
force-pushed
the
export-D101824526
branch
from
c9396a3 to
8f62f6b
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 21, 2026
Summary: **Context**: This was deprecated in Ax 1.0.0 and has not done anything since then. **This PR**: * Removes `generated_points` argument to `RandomGenerator` * Removes places where this is passed (which would have been recursively triggering the warning) Reviewed By: saitcakmak Differential Revision: D101824526
esantorella
force-pushed
the
export-D101824526
branch
from
8f62f6b to
f8c2ea8
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: facebook#5186 **Context**: This was deprecated in Ax 1.0.0 and has not done anything since then. **This PR**: * Removes `generated_points` argument to `RandomGenerator` * Removes places where this is passed (which would have been recursively triggering the warning) Reviewed By: saitcakmak Differential Revision: D101824526
esantorella
force-pushed
the
export-D101824526
branch
2 times, most recently
from
32a4e58 to
ff17523
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 23, 2026
Summary: **Context**: This was deprecated in Ax 1.0.0 and has not done anything since then. **This PR**: * Removes `generated_points` argument to `RandomGenerator` * Removes places where this is passed (which would have been recursively triggering the warning) Reviewed By: saitcakmak Differential Revision: D101824526
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5186 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 617 617
Lines 69312 69309 -3
=======================================
- Hits 66840 66838 -2
+ Misses 2472 2471 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: **Context**: This was deprecated in Ax 1.0.0 and has not done anything since then. **This PR**: * Removes `generated_points` argument to `RandomGenerator` * Removes places where this is passed (which would have been recursively triggering the warning) Reviewed By: saitcakmak Differential Revision: D101824526
esantorella
force-pushed
the
export-D101824526
branch
from
ff17523 to
0b371c5
Compare
|
This pull request has been merged in 98c7fd1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context: This was deprecated in Ax 1.0.0 and has not done anything since then.
This PR:
generated_pointsargument toRandomGeneratorReviewed By: saitcakmak
Differential Revision: D101824526